Re: virtio: Add memory statistics reporting to the balloon driver(V3)

From: Avi Kivity
Date: Thu Nov 19 2009 - 11:14:02 EST


On 11/19/2009 05:58 PM, Adam Litke wrote:
On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote:
On 11/19/2009 05:19 PM, Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this patch for
inclusion. Thanks.

+struct virtio_balloon_stat
+{
+ __le16 tag;
+ __le64 val;
+};
+

You're not doing endian conversion in the host?
No. I was following by example. For the virtio_balloon, the existing
code is careful so that the guest always writes data in little endian.

I don't follow. If the guest is careful to write little-endian, surely the host must be equally careful to read little-endian?

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/