Re: [patch] sched: fix set_task_cpu() and provide an unlockedrunqueue variant

From: Mike Galbraith
Date: Wed Nov 25 2009 - 20:31:18 EST


On Thu, 2009-11-26 at 02:01 +0100, Mike Galbraith wrote:
> On Wed, 2009-11-25 at 19:27 +0100, Peter Zijlstra wrote:

> > I've got to ask, what's that barrier for?
>
> It's a leftover from frustrated bug hunting.

To be more specific, I put it there to ensure that min_vruntimes are
stable. I figured that if try_to_wake_up() needs a barrier to look at
task->state, I had better do the same for the runqueues.

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/