Re: [PATCH 05/41] VFS: Make real_lookup() return a struct path

[Erez Zadok]

In message <1256152779-10054-6-git-send-email-vaurora@xxxxxxxxxx>, Valerie Aurora writes:
> From: Jan Blunck <jblunck@xxxxxxx>
> 
> This patch changes real_lookup() into returning a struct path.
> 
> Signed-off-by: Jan Blunck <jblunck@xxxxxxx>
> Signed-off-by: Valerie Aurora <vaurora@xxxxxxxxxx>
> ---
>  fs/namei.c |   82 +++++++++++++++++++++++++++++++++++++----------------------
>  1 files changed, 51 insertions(+), 31 deletions(-)
> 
> diff --git a/fs/namei.c b/fs/namei.c
> index 9c9ecfa..a338496 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -462,10 +462,11 @@ ok:
>   * make sure that nobody added the entry to the dcache in the meantime..
>   * SMP-safe
>   */
> -static struct dentry * real_lookup(struct dentry * parent, struct qstr * name, struct nameidata *nd)
> +static int real_lookup(struct nameidata *nd, struct qstr *name,
> +		       struct path *path)
>  {

Same comments I had on patch 3:

- document in comment and patch header the new @path parameter, who is
  responsible for it, new return err, etc.

- consider adding BUG_ON(!path)

- perhaps VFS this should also be pushed upstream before UM

Erez.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/