Re: [tip:perf/core] trace_syscalls: Remove unusedevent_syscall_enter and event_syscall_exit

[Frederic Weisbecker]

On Wed, Dec 02, 2009 at 09:13:50AM +0800, Lai Jiangshan wrote:
> Frederic Weisbecker wrote:
> 
> > 
> > Except for this patch. The whole series is really nice, thanks
> > a lot for this cleanup!
> > 
> > 
> > 
> 
> > But I think you fixed it the wrong way.
> > 
> > Why do we need a copy of this event_syscall_enter
> > for each syscall event?
> > Can't we actually drop enter_syscall_print_##sname
> > and always use event_syscall_enter instead?
> > 
> > The same applies to exit syscall events.
> > 
> > Thanks.
> > 
> 
> 64c12e0444fcc6b75eb49144ba46d43dbdc6bc8f is a nice patch from
> Jason Baron, this patch introduces enter_syscall_print_##sname.
> 
> This patch only forgot to do some cleanups. My patch make up it:
> 
> fix event_enter_##sname->event
> fix event_exit_##sname->event
> 
> remove unused event_syscall_enter and event_syscall_exit
> 
> Thanks,
> Lai


Ah right I forgot about this. We need different enter_syscall_print_##sname
so that we can have different event ids for each syscalls.

Ok, fine then, thanks :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/