Re: [PATCH v2] [RFC] tracepoint: Add signal coredump tracepoint
From: Masami Hiramatsu
Date: Thu Dec 03 2009 - 06:30:32 EST
Ingo Molnar wrote:
>
> * Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>
>> Add signal coredump tracepoint which shows signal number, mm->flags,
>> limits, pointer to file structure and core file name.
>
> Why is the kernel pointer to the file structure logged? User-space has
> no use for it and the analysis value is low.
Ah, if open() or opening pipe fails, it becomes 0 or -ERRNO,
so we can check if there is an error.
Perhaps, we can do below in trace_printk for trace users.
"open %s", (!file || IS_ERR((void *)file)) ? "failed" : "succeeded"
Thank you,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/