Re: [uClinux-dev] [PATCH/RFC] FDPIC: add hook for arches to customize program header parsing

[David Howells]

Mike Frysinger <vapier@xxxxxxxxxx> wrote:

> The Blackfin port has custom program header flags/addresses for
> automatically loading regions into the dedicated on-chip SRAM.  So add a
> hook for ports to leverage.

Now that I've ACK'd this, I feel I'm going to have to NAK it.  I'm not against
the general concept, but:

> +		do_munmap(mm, *maddr, phdr->p_memsz + *disp);

There needs to be a mapping covering the SRAM region for the purposes of the
debugger.  Do you have a chardev covering the SRAM device?  Perhaps through
MTD?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/