Re: [PATCH 06/31] Constify struct e1000_mac_operations for 2.6.32v1
From: Emese Revfy
Date: Fri Dec 04 2009 - 20:17:31 EST
Stephen Rothwell wrote:
> Hi Emese,
>
> On Sat, 05 Dec 2009 01:03:03 +0100 Emese Revfy <re.emese@xxxxxxxxx> wrote:
>> --- a/drivers/net/e1000e/82571.c
>> +++ b/drivers/net/e1000e/82571.c
>> @@ -212,6 +212,7 @@ static s32 e1000_init_mac_params_82571(struct e1000_adapter *adapter)
>> {
>> struct e1000_hw *hw = &adapter->hw;
>> struct e1000_mac_info *mac = &hw->mac;
>> + /* cannot be const */
>> struct e1000_mac_operations *func = &mac->ops;
>
> Adding to the comment to say why it can't be const may allow us to fix
> this later ...
Ok, in the next patch series I will explain each case.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/