Re: [PATCH] x86: Put trampoline_data into readonly section.
From: H. Peter Anvin
Date: Sat Dec 05 2009 - 01:18:22 EST
On 12/04/2009 08:47 PM, Rakib Mullick wrote:
On 12/5/09, H. Peter Anvin<hpa@xxxxxxxxx> wrote:
On 12/04/2009 08:24 AM, Rakib Mullick wrote:
Perhaps the better thing would be to define trampoline_size as an
absolute symbol in arch/x86/kernel/trampoline_*.S, especially since it
probably generates bad code to subtract two global symbols like that.
But - trampoline_data is placed into - cpu init readonly data section.
And we are
referencing it from non-cpuinit function. ....... so I think the
problem remains.
Isn't it ? Or am I missing anything?
No, we're not actually referencing it at all. We're just using its
length, whereas in reality we actually have copied the code elsewhere
already.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/