Re: [PATCH 1/19] untangling do_mremap(), part 1

From: Al Viro
Date: Mon Dec 07 2009 - 14:43:13 EST


On Mon, Dec 07, 2009 at 11:35:16AM -0800, Linus Torvalds wrote:
>
>
> On Mon, 7 Dec 2009, Al Viro wrote:
> >
> > Which David? ;-) All sparc-related bits seem to have been ACKed by
> > davem.
>
> That's the David I meant. I've seen the ack, but the acks weren't actually
> quoted in your latest series.

Hugh had just caught a lovely piece of idiocy in do_brk() patch; that
call of get_unmapped_area() in there should take MAP_FIXED, not
MAP_FIXED | flags. Harmless (we do get MAP_FIXED anyway and the only
other flag that gets looked at by methods is MAP_SHARED, which is
ignored when file is NULL), but definitely bogus.

I'll fix that before sending a pull request.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/