Re: [PATCH] kmemcheck: make bitfield annotations truly no-ops whendisabled

From: Andrew Morton
Date: Mon Dec 07 2009 - 17:14:49 EST


On Sun, 6 Dec 2009 18:42:13 +0100
Vegard Nossum <vegard.nossum@xxxxxxxxx> wrote:

> It turns out that even zero-sized struct members (int foo[0];) will affect
> the struct layout, causing us in particular to lose 4 bytes in struct sock.
>
> This patch fixes the regression in CONFIG_KMEMCHECK=n case.

Which kernel version is the regression relative to?

Should we backport this into 2.6.32.x?

If so, we have a slight problem: someone did
s/MAYBE_BUILD_BUG_ON/BUILD_BUG_ON/ in linux-next (I have feeling it was
me ;)) so the patch I applied had that slight massaging. Perhaps the
-stable stalwarts can take care of that slight difference.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/