Re: [PATCH] ARM: Convert BUG() to use unreachable()

[David Daney]

Uwe Kleine-KÃnig wrote:
> Use the new unreachable() macro instead of for(;;);
>
> Signed-off-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>
> Cc: David Daney <ddaney@xxxxxxxxxxxxxxxxxx>

This looks fine to me.  The comment is somewhat redundant now, but still 
accurate.

Reviewed-by: David Daney <ddaney@xxxxxxxxxxxxxxxxxx>


> ---
>  arch/arm/kernel/traps.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
> index 3f361a7..25b50c4 100644
> --- a/arch/arm/kernel/traps.c
> +++ b/arch/arm/kernel/traps.c
> @@ -681,7 +681,7 @@ void __attribute__((noreturn)) __bug(const char *file, int line)
>  	*(int *)0 = 0;
>  
>  	/* Avoid "noreturn function does return" */
> -	for (;;);
> +	unreachable();
>  }
>  EXPORT_SYMBOL(__bug);
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/