[PATCH] mlx4_core: return a negative error value
From: Roel Kluin
Date: Sat Dec 12 2009 - 20:58:44 EST
The return value should be negative.
Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
---
drivers/net/mlx4/sense.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
This is a cleanup, its only caller, mlx4_do_sense_ports()
acts on any non-zero error values as well.
diff --git a/drivers/net/mlx4/sense.c b/drivers/net/mlx4/sense.c
index f36ae69..015fbe7 100644
--- a/drivers/net/mlx4/sense.c
+++ b/drivers/net/mlx4/sense.c
@@ -53,7 +53,7 @@ static int mlx4_SENSE_PORT(struct mlx4_dev *dev, int port,
if (out_param > 2) {
mlx4_err(dev, "Sense returned illegal value: 0x%llx\n", out_param);
- return EINVAL;
+ return -EINVAL;
}
*type = out_param;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/