Re: [Patch] console: limit the range of VGACON_SOFT_SCROLLBACK_SIZE

[BuraphaLinux Server]

On 12/25/09, Amerigo Wang <amwang@xxxxxxxxxx> wrote:
>
> BuraphaLinux reported that we will trigger a mm warning when
> we CONFIG_VGACON_SOFT_SCROLLBACK_SIZE=65536, this is because
> mm cann't allocate so many pages. We should limit the range
> of CONFIG_VGACON_SOFT_SCROLLBACK_SIZE, don't give a user
> any chance to trigger that.
>
> Reported-by: John Gatewood Ham <buraphalinuxserver@xxxxxxxxx>
> Signed-off-by: WANG Cong <amwang@xxxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
>
> ---
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index fc7d9bb..8e8f18d 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -37,6 +37,7 @@ config VGACON_SOFT_SCROLLBACK
>  config VGACON_SOFT_SCROLLBACK_SIZE
>         int "Scrollback Buffer Size (in KB)"
>         depends on VGACON_SOFT_SCROLLBACK
> +       range 1 1024
>         default "64"
>         help
>           Enter the amount of System RAM to allocate for the scrollback
>

This fixed the problem.  Thank you for the fix.  I texted on 2.6.32.2
with your patch added, x86_64 kernel.

Tested-by: John Gatewood Ham <buraphalinuxserver@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/