[patch] hamradio: avoid null deref v2
From: Dan Carpenter
Date: Sat Dec 26 2009 - 07:38:57 EST
Bump the stats on the original dev not on the newly assigned NULL version of
dev.
Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
--- orig/drivers/net/hamradio/bpqether.c 2009-12-22 23:58:56.000000000 +0200
+++ devel/drivers/net/hamradio/bpqether.c 2009-12-25 19:49:05.000000000 +0200
@@ -282,11 +282,12 @@ static netdev_tx_t bpq_xmit(struct sk_bu
bpq = netdev_priv(dev);
- if ((dev = bpq_get_ether_dev(dev)) == NULL) {
+ if (!bpq->ethdev) {
dev->stats.tx_dropped++;
kfree_skb(skb);
return NETDEV_TX_OK;
}
+ dev = bpq_get_ether_dev(dev);
skb->protocol = ax25_type_trans(skb, dev);
skb_reset_network_header(skb);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/