Re: [PATCH] perf_event: mount debugfs automatically

[Xiao Guangrong]

Ingo Molnar wrote:
> * Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx> wrote:
> 
>> Mount debugfs automatically if it's not mounted, umount it
>> when programme exit
>>
>> Signed-off-by: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxx>
>> ---
>>  tools/perf/perf.c         |   10 +++++++++-
>>  tools/perf/util/debugfs.c |   16 +++++++---------
>>  tools/perf/util/debugfs.h |    2 +-
>>  3 files changed, 17 insertions(+), 11 deletions(-)
> 
> I'm not sure that's a good idea. What happens if two perf tools are running in 
> parallel:
> 
>   perf report #1 start
>                           perf report #2 start
>   perf report #2 exit [umount debugfs]
>                           perf report #2 tries to open /debug file: kaboom
>                           perf report #2 exit
> 

Sorry, i not notice it, it can't work under this case.

> But your idea is sound if we only do the first half: we should mount it under 
> /sys/kernel/debug/ if it's not mounted already [and that directory is 
> available], and leave it mounted there.
> 

Um, i'll rewrite it and just mount it under /sys/kernel/debug

Thanks,
Xiao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/