Re: [PATCH] x86: slightly shorten __ticket_spin_trylock() (v3)

From: Ingo Molnar
Date: Mon Dec 28 2009 - 03:48:44 EST



* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, 18 Dec 2009, Jan Beulich wrote:
> >
> > -static __always_inline int __ticket_spin_trylock(arch_spinlock_t *lock)
> > +static __always_inline u8 __ticket_spin_trylock(arch_spinlock_t *lock)
>
[...]
>
> I dunno. I still don't get the feeling that any of this actually
> _matters_.

Jan, to apply this patch it would be nice to see a before/after
comparison/analysis of a defconfig vmlinux image with a reasonably uptodate
GCC - to see how much this all matters in practice.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/