Re: [PATCH 2/3] perf tools: remove pid option from stat

[Wang Liming]

Ingo Molnar wrote:
> * Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> > On Tue, 2009-12-29 at 16:37 +0800, Liming Wang wrote:
> > > pid option is useless for stat, so remove it.
> > Hmm, it shouldn't be.. and instead of removing it I would suggesting fixing 
> > this.
>
> Yes. For exampe something like:
>
>   perf stat --repeat 10 --pid $(pidof firefox) sleep 1
>
> Should show firefox's resource usage sampled over 10 seconds.
>
> If this doesnt work it should be fixed. Plus i suspect we should allow:
>
>   perf stat --pid $(pidof firefox)
>
> to run until Ctrl-C - like perf record allows.
Yes, perf record works well with "--pid".
I think stat can borrow come code from record.
Please discard this patch.

Liming Wang
> 	Ingo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/