Re: [PATCH] cfq-iosched: non-rot devices do not need queue merging

[Jens Axboe]

On Wed, Dec 30 2009, Corrado Zoccolo wrote:
> Non rotational devices' performances are not affected by
> distance of requests, so there is no point in having overhead
> to merge queues of nearby requests.

If the distance is zero, it may still make a big difference (at least
for writes). This check would be better as "ncq and doesn't suck", ala

        blk_queue_nonrot(q) && tagged

like we do elsewhere.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/