Re: Q. d_alloc() in pipe(2)

[Bill Davidsen]

hooanon05@xxxxxxxxxxx wrote:
> In pipe(2), create_write_pipe() creates a dentry by
> 	struct qstr name = { .name = "" };
> 	d_alloc(root, &name);
>
> But d_alloc() refers name->len which is uninitialized.
> Isn't it better to replace d_alloc() by d_alloc_name(root, "")?
If readability counts, I would say so. Functionally I don't know, I can't see 
any problems other than it's unobvious.

--
Bill Davidsen <davidsen@xxxxxxx>
  "We have more to fear from the bungling of the incompetent than from
the machinations of the wicked."  - from Slashdot
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/