Re: [PATCH] Valid relocation symbol for FLAT format on ARM

[Mike Frysinger]

On Sat, Dec 26, 2009 at 11:36, Jun Sun wrote:
> Apparently newer GCC would generate ANCHOR symbols beyond the end of
> data/bss segment on ARM CPUs. As a result, the exiting validity checking
> for relocation symbols in FLAT format will fail.
>
> This also fixes a cosmetic error in printk. Text segment and data/bss
> segment are allocated from two different areas. It is not meaningful to
> give the diff between them in error reporting messages.
>
> Signed-off-by: Jun Sun <jsun@xxxxxxxxxx>
>
> diff -Nru linux-2.6.32.2/arch/arm/include/asm/flat.h.orig linux-2.6.32.2/arch/arm/include/asm/flat.h

you really should use git to generate the patch.  if you're going to
do it by hand, you need to format it correctly.  you're missing the
--- marker between your change log and the start of the patch.

> --- linux-2.6.32.2/fs/binfmt_flat.c
> +++ linux-2.6.32.2/fs/binfmt_flat.c
> @@ -355,7 +355,7 @@
>
> Â Â Â Âif (!flat_reloc_valid(r, start_brk - start_data + text_len)) {
> Â Â Â Â Â Â Â Âprintk("BINFMT_FLAT: reloc outside program 0x%x (0 - 0x%x/0x%x)",
> - Â Â Â Â Â Â Â Â Â Â Â(int) r,(int)(start_brk-start_code),(int)text_len);
> + Â Â Â Â Â Â Â Â Â Â Â(int) r,(int)(start_brk-start_data+text_len),(int)text_len);
> Â Â Â Â Â Â Â Âgoto failed;
> Â Â Â Â}

this should be a separate patch since it is unrelated to your other change
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/