Re: [PATCH] [4/6] kfifo: add kfifo_out_peek

[Alan Cox]

> > Bloat is going to be a big issue if its macro and all the serial/tty
> > stuff switches to it. Please keep the bytewise one none macro - even if
> > its a lib/foo.c file that simply uses the macros to produce the existing
> > new API.
> 
> Nope, currently the bytewise is the special case. Most of the user of
> kfifo try to store other type then bytes in a fifo. 

If the tty layer switches to it then the bytewise one will dominately
quite rapidly as it can replace the uart_circ stuff

> The new macro based kfifo does not bloat the code, the opposite is the
> truth. I checked the assembler output on intel and ppc and the generated
> code is smaller and better.

Thats excellent

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/