Re: [PATCH v2] port ricoh_mmc to be pci quirk

[Maxim Levitsky]

On Thu, 2009-11-26 at 23:55 -0800, Philip Langdale wrote: 
> On Fri, 27 Nov 2009 01:53:04 +0200
> Maxim Levitsky <maximlevitsky@xxxxxxxxx> wrote:
> 
> > >From 2d3002e29c329d76ca4e26d9f427814151a9648c Mon Sep 17 00:00:00
> > >2001
> > From: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> > Date: Fri, 27 Nov 2009 00:53:28 +0200
> > Subject: [PATCH] port ricoh_mmc to be pci quirk
> > 
> > This patch solves nasty problem original driver has.
> > Original goal of the ricoh_mmc was to disable this device because
> > then, mmc cards can be read using standard SDHCI controller,
> > thus avoiding writing of yet another driver.
> > However, the act of disablement, makes other pci functions that
> > belong to this controller (xD and memstick) shift up one level, thus
> > pci core has now wrong idea about these devices.
> > 
> > To fix this issue, this patch moves the driver into pci quirk
> > section, thus it is executes before the pci is enumerated, and
> > therefore solving that issue, also same sequence of commands is
> > performed on resume for same reasons.
> > 
> > Also regardless of the above, this way is cleaner.
> > 
> > You still need to set CONFIG_MMC_RICOH_MMC
> > to enable this quirk
> 
> I like it. Only comment is that I'd like the printks to identify which
> controller is involved. If Andrew is happy with the CONFIG mechanism,
> then you've got an ack from me.
> 
> Thanks for doing this.

Hi, do you plan to include this patch in the kernel?

BTW, I did write successfully the driver for the xD controller, so now
this is a real problem.

Best regards,
Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/