Re: [PATCH] Make Intel 8-way Xeons boot again

[Yinghai Lu]

On Sat, Jan 9, 2010 at 2:10 AM, Ananth N Mavinakayanahalli
<ananth@xxxxxxxxxx> wrote:
> On an 8-way system with Intel Xeon X7350 CPUs, booting 2.6.32 or newer
> kernels fails at:
>
> ...
> CPU0: Intel(R) Xeon(R) CPU           X7350  @ 2.93GHz stepping 0b
> Booting Node   0, Processors  #1 #2 #3 #4 #5 #6 #7 Ok.
> Brought up 8 CPUs
> Total of 8 processors activated (46906.05 BogoMIPS).
>
> Git bisect showed 2fbd07a5f as the offending commit.
>
> With the patch below, I am able to boot the latest Linus' git tree on
> the machine. If this patch is correct, it needs to get into the stable
> tree too.
>
> Signed-off-by: Ananth N Mavinakayanahalli <ananth@xxxxxxxxxx>
> ---
> Index: linux-2.6/arch/x86/kernel/apic/probe_64.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/apic/probe_64.c      2010-01-09 14:54:29.000000000 +0530
> +++ linux-2.6/arch/x86/kernel/apic/probe_64.c   2010-01-09 14:57:53.000000000 +0530
> @@ -70,7 +70,7 @@
>        if (apic == &apic_flat) {
>                switch (boot_cpu_data.x86_vendor) {
>                case X86_VENDOR_INTEL:
> -                       if (num_processors > 8)
> +                       if (num_processors >= 8)
>                                apic = &apic_physflat;
>                        break;
>                case X86_VENDOR_AMD:

can you send out whole bootlog with apic=debug?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/