Re: [PATCH 2/7] sysfs: Pack sysfs_dirent more tightly.

From: Tejun Heo
Date: Mon Jan 11 2010 - 19:39:55 EST


On 01/12/2010 05:21 AM, Eric W. Biederman wrote:
> From: Eric W. Biederman <ebiederm@xxxxxxxxxxxxxxxxxx>
>
> Placing the 16bit s_mode between a pointer and a long doesn't pack well
> especailly on 64bit where we wast 48 bits. So move s_mode and
> declare it as a unsigned short. This is the sysfs backing store
> after all we don't need fields extra large just in case someday
> we want userspace to be able to use a larger value.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxxxxxxxx>

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/