Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/oKMS

From: Eric Anholt
Date: Tue Jan 12 2010 - 17:33:16 EST


On Sat, 9 Jan 2010 00:45:33 +0100, "Rafael J. Wysocki" <rjw@xxxxxxx> wrote:
> From: Rafael J. Wysocki <rjw@xxxxxxx>
>
> Commit cbda12d77ea590082edb6d30bd342a67ebc459e0 (drm/i915: implement
> new pm ops for i915), among other things, removed the .suspend and
> .resume pointers from the struct drm_driver object in i915_drv.c,
> which broke resume without KMS on my MSI Wind U100.
>
> Fix this by reverting that part of commit cbda12d77ea59.
>
> Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>

Applied, with a little comment for the next poor person having to figure
out the difference between these two suspend/resume paths.

(And yes, I'd love to see the stealth mode die sometime soonish. It's
not like attaching intelfb didn't make the user-mode 2D driver fail
frequently, so it's not a great "feature" for us to be maintaining
support for. From what I understand most distros blacklisted the
intelfb driver anyway.)

Attachment: pgp00000.pgp
Description: PGP signature