Re: [PATCH] alsa: use subsys_initcall for sound core instead ofmodule_init

[Thadeu Lima de Souza Cascardo]

On Thu, Jan 14, 2010 at 05:18:26PM +0100, Takashi Iwai wrote:
> At Thu, 14 Jan 2010 13:53:43 -0200,
> Thadeu Lima de Souza Cascardo wrote:
> > 
> > On Wed, Jan 13, 2010 at 07:48:07AM +0100, Takashi Iwai wrote:
> > > At Tue, 12 Jan 2010 20:20:39 -0200,
> > > Thadeu Lima de Souza Cascardo wrote:
> > > > 
> > > > This is needed for built-in drivers which are built before the sound directory,
> > > > like thinkpad_acpi.
> > > > 
> > > > Otherwise, registering a card fails.
> > > 
> > > Oh well, this kind of problem hits again.
> > > 
> > > I don't remember why subsys_init() wasn't taken before...  Maybe some
> > > dependency between sound and V4L or so.  But, it's worth to check again.
> > > 
> > 
> > Any references to this dependency problem, so I can try to help and investigate
> > about it and do some tests?
> 
> I also don't remember.  That was a long long ago... :)
> 
> > > I'll apply this after some testing.
> > > 
> > 
> > Built-in thinkpad-acpi started working for me after these changes. I can't tell
> > you about any subsystem that stopped working, like some V4L driver.
> 
> Did you test whether the sound subsystem still works as modules?
> 

It does. I've just reapplied those patches on top of rc4, and I'm currently
running it with CONFIG_SOUND=m, and my sound card works nicely, thanks.

> 
> Takashi

Attachment: signature.asc
Description: Digital signature