Re: [PATCH 39/40] gfs2: use workqueue instead of slow-work
From: Tejun Heo
Date: Mon Jan 18 2010 - 06:26:58 EST
On 01/18/2010 06:45 PM, Steven Whitehouse wrote:
> On Mon, 2010-01-18 at 09:57 +0900, Tejun Heo wrote:
>> Workqueue can now handle high concurrency. Use system_long_wq instead
>> of slow-work.
>> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
>> Cc: Steven Whitehouse <swhiteho@xxxxxxxxxx>
> Acked-by: Steven Whitehouse <swhiteho@xxxxxxxxxx> on two conditions:
> i) That scheduling work on this new workqueue will not require any
> GFP_KERNEL allocations (even hidden ones such as starting new threads)
> before the work runs. This is required since the recovery code must not
> call into the fs until after its recovered.
Oh, if that's the case, it needs its own wq with a rescuer. I thought
the recovery path wasn't invoked during allocation. slow-work didn't
guarantee such thing either. Anyways, changing that is pretty easy.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/