Re: [PATCH] regulator: mc13783: consider Power Gates as digitalregulators.

From: Uwe Kleine-König
Date: Mon Jan 18 2010 - 14:04:57 EST

Hello Alberto,

Can you post an updated patch addressing the discussion with Mark,

>From the first look I don't like the name
MC13783_REG_POWERMISC_PWGTSPI_M as I don't understand it's purpose
without going through mc13783_reg_rmw_powermisc (which I didn't do yet).

What is the base for your patch? (Hm, it seems next could work.
mc13783-regulator seems to have gotten some more #defines ending in _M.
You seem to mean "mask". IMHO it's a bit unfortunate, because the
nameing scheme doesn't match the already existing names :-()

Shouldn't mc13783_state_powermisc_pwgt be a per-device variable instead
of a static variable?

Best regards

Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | |
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at