Re: mcs7830 usb net: "scheduling while atomic" danger?

From: Thomas Gleixner
Date: Mon Jan 18 2010 - 16:24:28 EST


On Mon, 18 Jan 2010, Julia Lawall wrote:
> On Mon, 18 Jan 2010, Andreas Mohr wrote:
> The semantic match shown below finds 55 matches. All but two involve
> mutex_lock. Those are in the file

As I said before the mutex_lock()/msleep() ones are fine.

> /var/linuxes/linux-next/drivers/usb/host/ehci-hub.c
> in the functions ehci_bus_suspend and ehci_hub_control.

The msleep in ehci_hub_control() which happens with ehci->lock held
and irqs disabled is definitely buggy.

I can't see anything wrong wth the msleep in ehci_bus_suspend() as it
is _before_ the spin_lock_irq(&ehci->lock) region.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at