RE: mcs7830 usb net: "scheduling while atomic" danger?
From: Du, Alek
Date: Mon Jan 18 2010 - 21:54:05 EST
I confirm that thing is bad, I need to prepare another patch to fix that.
>From: Arnd Bergmann [mailto:arnd@xxxxxxxx]
>Sent: Tuesday, January 19, 2010 5:24 AM
>To: Julia Lawall
>Cc: Andreas Mohr; linux-kernel@xxxxxxxxxxxxxxx; Greg KH; Du, Alek; Pan, Jacob
>jun; Alan Stern
>Subject: Re: mcs7830 usb net: "scheduling while atomic" danger?
>On Monday 18 January 2010, Julia Lawall wrote:
>> On Mon, 18 Jan 2010, Andreas Mohr wrote:
>> > Forgive me, but doesn't that mutex_lock()/msleep() (ab)use mean
>> > risking a "scheduling while atomic"?
>> > (such as discussed in e.g.
>> > http://search.luky.org/linux-kernel.2004/msg92817.html )
>> > And, if that is the case, shouldn't all such cases simply be killed for
>> > good via a capable semantic patch?
>> The semantic match shown below finds 55 matches. All but two involve
>> mutex_lock. Those are in the file
>> in the functions ehci_bus_suspend and ehci_hub_control.
>That code looks indeed broken as was added las July as part of 331ac6b288d9
>"USB: EHCI: Add Intel Moorestown EHCI controller HOSTPCx extensions and
>support phy low power mode". The reason that this hasn't triggered is
>probably the lack of Moorestown machines in the field.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/