Re: [PATCH] kconfig: dont hardcode path to lsmod

From: John Kacur
Date: Tue Jan 19 2010 - 12:38:42 EST




On Tue, 19 Jan 2010, Steven Rostedt wrote:

> On Tue, 2010-01-19 at 17:29 +0100, John Kacur wrote:
>
> > diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
> > index 0d80082..1803d2e 100644
> > --- a/scripts/kconfig/streamline_config.pl
> > +++ b/scripts/kconfig/streamline_config.pl
> > @@ -238,7 +238,8 @@ foreach my $makefile (@makefiles) {
> > my %modules;
> >
> > # see what modules are loaded on this system
> > -open(LIN,"/sbin/lsmod|") || die "Cant lsmod";
> > +# If lsmod isn't in the sbin dir, check if it is in the path
> > +open(LIN,"/sbin/lsmod|") || open(LIN,"lsmod|") || die "Cant lsmod";
>
> I've tried this before, but it gives an error that the "|" pipe failed.
>
> -- Steve
>
>
> > while (<LIN>) {
> > next if (/^Module/); # Skip the first line.
> > if (/^(\S+)/) {
>
>

Are you sure? It works for my test toy program.
First tested with the hardcoded path, and then giving a nonsense name
instead of sbin so that it uses the PATH variable.

John
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/