Re: [PATCH 4/6] tracing: Change trace_seq to use separate buffer

From: Frederic Weisbecker
Date: Wed Jan 20 2010 - 13:41:04 EST

On Tue, Jan 19, 2010 at 03:34:16PM +0800, Lai Jiangshan wrote:
> @@ -3124,6 +3126,8 @@ waitagain:
> if (cnt >= PAGE_SIZE)
> cnt = PAGE_SIZE - 1;
> + trace_seq_reset(&iter->seq);
> +

So we actually add a trace_seq_reset here.
This should have been in the first patch, which drops
the memset, and eventually modified here, just to avoid
breaking things in the middle of a patchset.

Things were already broken though before the memset dropping
patch though in other ways, so it's not that important I guess...

The patch looks good.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at