Re: qlogic lockdep warning

From: Xiaotian Feng
Date: Thu Jan 21 2010 - 04:14:27 EST

On Thu, Jan 21, 2010 at 5:02 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Thu, 2010-01-21 at 16:46 +0800, Xiaotian Feng wrote:
>> qla24xx_msix_default is using spin_lock_irq and spin_unlock_irq within
>> the irq handler...
>> I think convert to spin_lock_irqsave/spin_unlock_irqrestore can solve
>> this warning.
> Not only that it'll actually solve a bug too ;-)
> Also,
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?

Ah, just realized it by your examples :-) Sorry for the bad manner in e-mail...

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at