RE: [PATCH] bfa: comparison with wrong msgtag in bfa_pport_isr()
From: Jing Huang
Date: Thu Jan 21 2010 - 20:59:43 EST
> Was this maybe intended? otherwise in case BFI_PPORT_I2H_ENABLE_RSP:
> the same code is executed. Please review.
Making this change alone will break compilation since bfa_pport_disable_rsp_s is not defined. To fix this, we should also replace it with bfa_pport_generic_rsp_s in bfi_pport_i2h_msg_u.
But please keep this as it is for now since I am working on resubmitting 126.96.36.199 patch, and there are a lot of changes in this area.
> diff --git a/drivers/scsi/bfa/bfa_fcport.c b/drivers/scsi/bfa/bfa_fcport.c
> index aef648b..f00d07b 100644
> --- a/drivers/scsi/bfa/bfa_fcport.c
> +++ b/drivers/scsi/bfa/bfa_fcport.c
> @@ -918,7 +918,7 @@ bfa_pport_isr(struct bfa_s *bfa, struct bfi_msg_s
> case BFI_PPORT_I2H_DISABLE_RSP:
> - if (pport->msgtag == i2hmsg.enable_rsp->msgtag)
> + if (pport->msgtag == i2hmsg.disable_rsp->msgtag)
> bfa_sm_send_event(pport, BFA_PPORT_SM_FWRSP);
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/