Re: [PATCH 00/24] drivers/block/floppy.c cleanups

From: Alan Cox
Date: Fri Jan 22 2010 - 06:45:19 EST

> Philosophically I'm not sure it's that great an idea to make bad code
> look better without actually fixing/rewriting it. It's like putting
> lipstick on a pig.

Unpacking the mess and sorting out the whacky macros is more like
removing all muck from the mechanism so you can see what needs to be done.

So I disagree - its a useful first step only
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at