Re: [PATCH 3/4] MTD: blkdevs: make hotplug work

From: Artem Bityutskiy
Date: Fri Jan 22 2010 - 11:01:09 EST

On Fri, 2010-01-22 at 17:35 +0200, Maxim Levitsky wrote:
> >From 368127067f4d39ba89096e4a5cb3be2dee361bad Mon Sep 17 00:00:00 2001
> From: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> Date: Fri, 22 Jan 2010 15:00:55 +0200
> Subject: [PATCH 3/4] MTD: blkdevs: make hotplug work
> This changes the blkdev common module for translation layers
> to survive when underlying mtd device disappears.
> To do so the following conceptual changes were made:
> * disk queue and thread are now one per mtd device
> This was it is easy to flush and destroy the queue
> * the struct mtd_blktrans_dev will now be freed automaticly when last user
> of the device quits.
> All existing translation layers are adjusted
> * ->open and release function of the translation layer will never be called
> twise or more in the row.
> This makes code simplier.
> Also the ->release will be called just before mtd device disappears
> This and above is the only visable changes on the outside.
> Tested with mtdblock, ssfdc and my own sm_ftl on top of physicly hotplugable
> nand card.
> Signed-off-by: Maxim Levitsky <maximlevitsky@xxxxxxxxx>

I'll try to find some time to review this later - I'm really busy
lately. But please, split this huge patch on smaller pieces - this will
help the reviewers a lot.

Best Regards,
Artem Bityutskiy (ÐÑÑÑÐ ÐÐÑÑÑÐÐÐ)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at