Re: [PATCH] teach git log to use --no-color --UPDATED

From: Richard Kennedy
Date: Sat Jan 23 2010 - 09:48:42 EST

When git has been set to always use color in .gitconfig then I get the
warning message

Bad divisor in main::vcs_assign: 0

This is caused by vcs_file_signoffs not matching any commits due to the
pattern not understand the colour codes. Fix this by telling git log to
never use colour.

Updated to fix both calls to 'git log' as requested by Joe Perches

Signed-off-by: Richard Kennedy <richard@xxxxxxxxxxxxxxx>

patch against 2.6.33-rc5
git --version 1.6.6

Hi Joe,
will this do?


diff --git a/scripts/ b/scripts/
index 090f248..2f3230d 100755
--- a/scripts/
+++ b/scripts/
@@ -74,8 +74,8 @@ my %VCS_cmds;
my %VCS_cmds_git = (
"execute_cmd" => \&git_execute_cmd,
"available" => '(which("git") ne "") && (-d ".git")',
- "find_signers_cmd" => "git log --since=\$email_git_since -- \$file",
- "find_commit_signers_cmd" => "git log -1 \$commit",
+ "find_signers_cmd" => "git log --no-color --since=\$email_git_since -- \$file",
+ "find_commit_signers_cmd" => "git log --no-color -1 \$commit",
"blame_range_cmd" => "git blame -l -L \$diff_start,+\$diff_length \$file",
"blame_file_cmd" => "git blame -l \$file",
"commit_pattern" => "^commit [0-9a-f]{40,40}",

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at