Re: [PATCH] - Fix unmap_vma() bug related to mmu_notifiers
From: Jack Steiner
Date: Mon Jan 25 2010 - 16:10:50 EST
On Mon, Jan 25, 2010 at 08:00:52PM +0100, Andrea Arcangeli wrote:
> On Mon, Jan 25, 2010 at 11:45:56AM -0600, Jack Steiner wrote:
> > unmap_vmas() can fail to correctly flush the TLB if a
> > callout to mmu_notifier_invalidate_range_start() sleeps.
> Not sure I understand: the callbacks invoked by
> mmu_notifier_invalidate_range_start can't sleep, or rcu locking inside
> mmu notifier will break too (first thing that should be replaced with
> srcu if they were allowed to sleep).
> In short there's no schedule that could be added because of those
> callbacks so if this code isn't ok and schedules and screw on the
> mmu_gather tlb it's probably not mmu notifier related.
Hmmmm. I was under the impression that the range callbacks _were_ allowed to
sleep. That was certainly in the original patches posted by christoph. I was
not aware that it had changed.
I'll let Robin provide details but the way mmu_notifiers are used by
xpmem, I believe sleeping is essential. The 'start" callout sends messages to
another OS instances to teardown cross-SSI mappings. That is difficult
to do w/o a sleep.
We'll dig deeper tomorrow & see what we can do....
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/