Re: sysfs_ops show vector: size of buffer not required?
From: Greg KH
Date: Mon Jan 25 2010 - 23:46:50 EST
On Sun, Jan 24, 2010 at 01:11:18PM +0530, Himanshu Chauhan wrote:
> Hi All,
> The sysfs_ops's show vector doesn't have a size of the
> buffer given to the vector, while store on the other hand
> has. What is the rationale behind it?
If you need to check the size, you are doing something wrong.
Seriously, that is the reason. A sysfs file should be a single value,
which will never overflow the buffer.
> I see most of the implementations doing strcpy in the
> show vectors. Ill behaved driver might overwrite the
> given buffer when size is not known. Should this be addressed
> by providing the buffer size along with the buffer pointer?
Again, a single value only, it easily fits into the buffer size.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/