Re: [PATCH 1/4] gpiolib: Introduce chip addition/removal notifier

From: David Brownell
Date: Tue Jan 26 2010 - 16:01:26 EST

On Tuesday 26 January 2010, Anton Vorontsov wrote:
> > Just
> > inline the little two blocking_notifier_call_chain() calls directly,
> > making this a *LOT* simpler.
> I'd rather stay with gpio_call_chain() helper, it makes the code
> a little bit prettier, IMO. Compare this:

The one without the wrapper is IMO more clear, since it doesn't
obfuscate anything. Fewer lines of code, too. :)

Pretty is a good attribute ... but is a distant third to clarity.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at