On Mon, 2010-01-25 at 23:48 -0600, Matt Mackall wrote:Hmm. I'd just as soon drop it entirely. Here's a patch. Herbert, you
want to send this through your crypto tree?
random: drop weird m_time/a_time manipulation
No other driver does anything remotely like this that I know of except
for the tty drivers, and I can't see any reason for random/urandom to do
it. In fact, it's a (trivial, harmless) timing information leak. And
obviously, it generates power- and flash-cycle wasting I/O, especially
if combined with something like hwrngd. Also, it breaks ubifs's
Signed-off-by: Matt Mackall <mpm@xxxxxxxxxxx>
diff -r 29db0c391ce8 drivers/char/random.c
--- a/drivers/char/random.c Sun Jan 17 11:01:16 2010 -0800
+++ b/drivers/char/random.c Mon Jan 25 23:32:00 2010 -0600
@@ -1051,12 +1051,6 @@
/* like a named pipe */
- * If we gave the user some bytes, update the access time.
- if (count)
return (count ? count : retval);
@@ -1116,8 +1110,6 @@
- inode->i_mtime = current_fs_time(inode->i_sb);
It may brake other FSes expectations, theoretically, as well.
Anyway, I'm perfectly fine if this is removed.
Jeff, could you please try Matt's patch and report back if you still
have issues or not. If no, you can use this as a temporary work-around
until a proper fix hits upstream or ubifs-2.6.git.
Description: GNU Zip compressed data