Re: [PATCH] drm/i915: Selectively enable self-reclaim

From: Linus Torvalds
Date: Wed Jan 27 2010 - 07:29:55 EST

On Wed, 27 Jan 2010, Linus Torvalds wrote:
> Setting the mapping gfp mask like that is totally wrong. Yes, it looks
> like you take the 'struct_mutex' lock, but I don't think the page fault
> does that, does it? So the locking in no way protects other uses of that
> mapping gfp mask.

Actually, it looks like the gem_fault code _does_ take the lock. So I
guess it's technically correct. If still really really ugly.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at