Re: [PATCH] Generic PS/2 mouse detected on Fujitsu LifebookB-Series model laptop instead of LBPS/2 Fujitsu Lifebook TouchScreen

From: Andrew Morton
Date: Wed Jan 27 2010 - 18:55:32 EST


(suitable cc's added)

On Mon, 25 Jan 2010 16:12:43 +0000
jon - <crayzeejon@xxxxxxxxx> wrote:

> From: Jon Dodgson <crayzeejon@xxxxxxxxx>
>
> Fix Detection of Lifebook B-Series Laptop touch screen with DMI
> product Name string 'Lifebook B Series'
>
> Signed-off-by: Jon Dodgson <crayzeejon@xxxxxxxxx>
>
> ---
> diff -Nurb linux-2.6.26.2/drivers/input/mouse/lifebook.c
> linux-2.6.26.2_patched/drivers/input/mouse/lifebook.c
> --- linux-2.6.26.2/drivers/input/mouse/lifebook.c 2008-08-06
> 17:19:01.000000000 +0100
> +++ linux-2.6.26.2_patched/drivers/input/mouse/lifebook.c 2010-01-25
> 02:56:41.000000000 +0000
> @@ -51,6 +51,12 @@
> {
> .ident = "LifeBook B",
> .matches = {
> + DMI_MATCH(DMI_PRODUCT_NAME, "Lifebook B Series"),
> + },
> + },
> + {
> + .ident = "LifeBook B",
> + .matches = {
> DMI_MATCH(DMI_PRODUCT_NAME, "LifeBook B Series"),
> },
> },

So the problem is "LifeBook" versus "Lifebook"? These matches are
case-sensitive?

I don't know what kernel you were patching, but current kernels no
longer have the ".ident" initialisation in that table. If it _was_
still there then I'd wonder why you set the ident to "LifeBook B"
rather than "Lifebook B".

Your email client wordwrapped the patch and replaced its tabs with
spaces.

Anyway, thanks. Please work this with Dmitry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/