Re: [PATCH] lpfc: Positive error return into negative

From: James Smart
Date: Fri Jan 29 2010 - 14:31:33 EST

This is innoculous as the code really only cares whether it's zero or non-zero. But, there's no harm in being consistent.

Acked-by: James Smart <>

-- james s

Roel Kluin wrote:
In the comment on top of lpfc_sli_hbq_setup() and of its caller which
transmits this error, lpfc_sli_hba_setup(), it is stated that the
function should return a negative error code.

Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 589549b..a960736 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -3709,7 +3709,7 @@ lpfc_sli_hbq_setup(struct lpfc_hba *phba)
phba->link_state = LPFC_HBA_ERROR;
mempool_free(pmb, phba->mbox_mem_pool);
- return ENXIO;
+ return -ENXIO;
phba->hbq_count = hbq_count;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at