Re: [PATCH v3] port ricoh_mmc to pci quirk
From: Maxim Levitsky
Date: Fri Jan 29 2010 - 17:10:45 EST
On Fri, 2010-01-29 at 08:06 -0800, Philip Langdale wrote:
> On Fri, 29 Jan 2010 15:37:35 +0200
> Maxim Levitsky <maximlevitsky@xxxxxxxxx> wrote:
> > Here, updated patch with your comments addressed.
> > This is also tested with real MMC card.
> Actual code gets my thumbs up.
> > This adds some > 80 chars lines, but I hope that is ok.
> It's against the coding style and as far as I can see, the only
> lines that are > 80 are the dev_notice and DECLARE_FIXUP lines - both
> of which can be trivially split across multiple lines, so please just
> do that.
Well, I have nothing against this, but, even Linus himself stated that
he dislikes broken printk lines.
I also noticed that some DECLARE_FIXUP in this file are longer that 80,
and since breaking this doesn't add any value, I thought that is ok.
Remember that main purpose of 80 char limit is to make code simpler.
However, I don't really care if you insist.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/