Re: Samsung N220 backlight support

[Christian Hesse]

On Saturday 30 January 2010 17:28:57 you wrote:
> On Sat, Jan 30, 2010 at 05:06:18PM +0100, Christian Hesse wrote:
> > Hello Greg,
> >
> > this adds support for Samsung N220 to your samsung-backlight. Tested on
> > my device, works for me.
> 
> Hm, the driver that ended up in the kernel is very different from this
> version.  Can you work with that version and add the needed changes
> there and generate a patch?

Oh, did not notice it was included in mainline already.
I applied the attached patch. Insmod now gives:

insmod: error inserting 'samsung-laptop.ko': -1 Invalid parameters

and the logs contain the following:

kernel: samsung_laptop: found laptop model 'N220'
kernel: This computer does not support SABI

What is this SABI and SECLINUX thing about? Do you have a link to any more 
information? Is it possible that the N220 does not have this?
The N220 uses a Pine Train platform (featuring N450 with 64bit support), so I 
installed x86_64 to the device.

I would be glad to test whatever you give me.

Regards,
Chris
--- linux-2.6.33-rc6/drivers/staging/samsung-laptop/samsung-laptop.c	2010-01-30 17:40:18.000000000 +0100
+++ linux-2.6.33-rc6/drivers/staging/samsung-laptop/samsung-laptop.c	2010-01-30 18:27:06.000000000 +0100
@@ -385,6 +385,15 @@ static struct dmi_system_id __initdata s
 		},
 		.callback = dmi_check_cb,
 	},
+	{
+		.ident = "N220",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "N220"),
+			DMI_MATCH(DMI_BOARD_NAME, "N220"),
+		},
+		.callback = dmi_check_cb,
+	},
 	{ },
 };
 MODULE_DEVICE_TABLE(dmi, samsung_dmi_table);