Re: [Patch - Resend v4] Memory-Hotplug: Fix the bug on interface/dev/mem for 64-bit kernel

From: Wu Fengguang
Date: Sun Jan 31 2010 - 23:42:46 EST


Some style nitpicks..

> +/**

Should use /* here.

> + * After memory hotplug, the variable max_pfn, max_low_pfn and high_memory will
> + * be affected, it will be updated in this function.
> + */
> +static inline void __meminit update_end_of_memory_vars(u64 start,

The "inline" and "__meminit" are both redundant here.

> + max_low_pfn = max_pfn = end_pfn;

One assignment per line is preferred.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at