Re: [Patch] net: export TCP send buffer size via netlink

[Cong Wang]

Eric Dumazet wrote:
> Le lundi 01 fÃvrier 2010 Ã 02:59 -0500, Amerigo Wang a Ãcrit :
> > Currently, we can only get TCP send buffer size by
> > getsockopt (SO_SNDBUF or TCP_INFO), this is not enough
> > for the tools like netstat or ss to read.
> >
> > Show TCP send buffer size via netlink NETLINK_INET_DIAG.
> >
> > Signed-off-by: WANG Cong <amwang@xxxxxxxxxx>
> > Cc: David Miller <davem@xxxxxxxxxxxxx>
> >
> > ---
> > diff --git a/include/linux/tcp.h b/include/linux/tcp.h
> > index 7fee8a4..46768de 100644
> > --- a/include/linux/tcp.h
> > +++ b/include/linux/tcp.h
> > @@ -136,6 +136,7 @@ struct tcp_info {
> >  	__u32	tcpi_ato;
> >  	__u32	tcpi_snd_mss;
> >  	__u32	tcpi_rcv_mss;
> > +	__u32	tcpi_sndbuf;
> >  
> >  	__u32	tcpi_unacked;
> >  	__u32	tcpi_sacked;
>
> You cannot change tcp_info like this, this structure is used by some
> programs, and they are going to break badly.

Oh, right, I forgot the ABI compatibility...
I will append it to this structure.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/