[PATCH] sched: Remove unused update_shares_locked()

From: Peter Zijlstra
Date: Mon Feb 01 2010 - 05:13:50 EST


On Mon, 2010-02-01 at 18:22 +1100, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next build (powerpc allyesconfig) produced this warning:
>
> kernel/sched.c:1636: warning: 'update_shares_locked' defined but not used
>
> Introduced by commit f492e12ef050e02bf0185b6b57874992591b9be1 ("sched:
> Remove load_balance_newidle()").

Hmm, you're quite right indeed, that removed the only user of that
function.

---
Subject: sched: Remove unused update_shares_locked()

Commit f492e12ef050e02bf0185b6b57874992591b9be1 ("sched: Remove
load_balance_newidle()") removed the only user of this function, so
remove it too.

Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
---
kernel/sched.c | 14 --------------
1 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 876e7c1..b5c8b44 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -1633,16 +1633,6 @@ static void update_shares(struct sched_domain *sd)
}
}

-static void update_shares_locked(struct rq *rq, struct sched_domain *sd)
-{
- if (root_task_group_empty())
- return;
-
- raw_spin_unlock(&rq->lock);
- update_shares(sd);
- raw_spin_lock(&rq->lock);
-}
-
static void update_h_load(long cpu)
{
if (root_task_group_empty())
@@ -1657,10 +1647,6 @@ static inline void update_shares(struct sched_domain *sd)
{
}

-static inline void update_shares_locked(struct rq *rq, struct sched_domain *sd)
-{
-}
-
#endif

#ifdef CONFIG_PREEMPT


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/