Re: [PATCH 2/2] ftrace: re-enable dynamic ftrace for ARM

[Uwe Kleine-König]

Hello,

On Mon, Feb 01, 2010 at 10:23:19PM +0530, Rabin Vincent wrote:
> On Mon, Feb 01, 2010 at 11:28:43AM +0100, Uwe Kleine-König wrote:
> > On Sun, Jan 31, 2010 at 11:03:16PM +0530, Rabin Vincent wrote:
> > > This adds mcount recording and updates dynamic ftrace for ARM to work
> > > with the new ftrace dyamic tracing implementation.
> [...]
> > Wouldn't it be nice to patch out the instruction pushing lr to the
> > stack (in the gnu case)?  Should work, shouldn't it.
> 
> It would and it should, but the main reasons I didn't do that were:
> 
>   - Thumb-2 support needs the LR to be in place, since even -mapcs-frame
>     does not seem to give us an APCS frame there.   The LR would also
>     be needed if GCC gains the ability to build without frame pointers
>     with -pg.
> 
>   - I'm not sure we would gain much performance by patching it out, and
>     I'd really like to avoid patching more than what is really necessary
>     and to keep the code as similar as possible to the other arches.
That's OK for me.  Then the only thing that would be nice would be some
more documentation.  E.g. how looks the function prologue in the two
cases, which of these instruction is patched?

This doesn't need to be a stopper for your patch, it's on my long term
todo list already to add some documentation to the (non-dynamic) ftrace
on arm.  I wouldn't mind to add the documentation myself, but not now.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/